New analyser: Fix Any kinds for special forms #7148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Jul 4, 2019
| @@ -156,6 +156,11 @@ def visit_name_expr(self, e: NameExpr) -> Type: | |||
| def analyze_ref_expr(self, e: RefExpr, lvalue: bool = False) -> Type: | |||
| result = None # type: Optional[Type] | |||
| node = e.node | |||
|
|
|||
| if isinstance(e, NameExpr) and e.is_special_form: | |||
There was a problem hiding this comment.
Do you know how did this work with the old semantic analyzer (i.e. why do we need this now)?
There was a problem hiding this comment.
Yes, this is again the story from #6458. Old analyzer generates a spurious Var as an lvalue node for special form assignments, and thus the type of lvalue is actually inferred (but still Any because this is what rvalue returns). The new analyzer doesn't do this, so that we fall through to the end in the if just below, thus getting TypeOfAny.from_error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7118
Previously left hand sides of special forms were inferred as
TypeOfAny.from_error. Note that total number of expressions in one of the tests is now smaller because of the subtle logic in visiting definitions of special forms, but I don't think it is import to keep it one-to-one with old analyser.