Allow passing path/to/file.py:line instead of fully.qualified.name to dmypy suggest #7483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couple observations:
|
msullivan
approved these changes
Sep 9, 2019
| @@ -285,13 +287,17 @@ def maybe_suggest(self, step: int, server: Server, src: str) -> List[str]: | |||
| try_text=try_text, flex_any=flex_any, | |||
| callsites=callsites)) | |||
| val = res['error'] if 'error' in res else res['out'] + res['err'] | |||
| if json: | |||
There was a problem hiding this comment.
Thanks for getting JSON tests working!
| modname, tail = target | ||
| node = None # type: Optional[SymbolNode] | ||
| if ':' in key: | ||
| file, line = key.split(':') |
There was a problem hiding this comment.
Add a count so a bad argument can't crash the daemon?
It looks like yes, I tried to play with this a bit more, and it looks like penalty is typically a bit lower, around 500ms (interpreted) for mypy self-suggest with some removed signatures. For compiled this would mean something like 1100ms vs 1200ms, so probably not worth it to try to optimize now (it affects only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with integrations with editors and IDEs, where getting line number of a function might be much easier than the full name.
The implementation in mostly straightforward. I also did a little refactoring to reuse the existing logic efficiently. The only important difference that I introduced after few experiments is that I force reloading of the file before trying to search the function, since even the smallest edit can offset the line number and lead to some weird results.