[mypyc] Fix using values from other modules that were reexported #7496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple parts to this: * Compile module attribute accesses by compiling the LHS on its own instead of by loading its fullname (which will be what mypy thinks its source is) * Only use the static modules if they have actually been imported Closes #393.
JukkaL
approved these changes
Sep 11, 2019
| self.imports = [] # type: List[str] | ||
| # We use an OrderedDict for this so we can maintain insertion order | ||
| # and do quick lookups | ||
| self.imports = OrderedDict() # type: OrderedDict[str, None] |
There was a problem hiding this comment.
Document this attribute. Maybe this would benefit from renaming -- it took me a while to figure out what it's used for.
| @@ -4645,3 +4645,18 @@ from native import foo | |||
|
|
|||
| assert foo(None) == None | |||
| assert foo([1, 2, 3]) == ((1, 2, 3), [1, 2, 3]) | |||
|
|
|||
| [case testReexport] | |||
There was a problem hiding this comment.
Maybe also test re-exporting a module or a class. What about re-exporting a global variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple parts to this:
instead of by loading its fullname (which will be what mypy thinks
its source is)
Closes mypyc/mypyc#393.
I ran into this again while finishing up my separate compilation PR and so got annoyed and fixed it.