Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 7478 #7504

Merged
merged 7 commits into from Sep 16, 2019

Conversation

@ckarnell
Copy link
Contributor

ckarnell commented Sep 12, 2019

Fix this issue: #7478

I reused an existing error message, but noticed it has a grammatical error where it uses the word "a", but in this case should use the word "an". I considered just removing "a", and decided against it because it would break other tests. Happy to change this error message if needed.

ckarnell added 6 commits Sep 12, 2019
@msullivan

This comment has been minimized.

Copy link
Collaborator

msullivan commented Sep 12, 2019

Yeah I'd say we should just remove the a

@msullivan

This comment has been minimized.

Copy link
Collaborator

msullivan commented Sep 12, 2019

Otherwise looks great

@ckarnell

This comment has been minimized.

Copy link
Contributor Author

ckarnell commented Sep 13, 2019

Went ahead and removed "a" and fixed related tests.

@ckarnell

This comment has been minimized.

Copy link
Contributor Author

ckarnell commented Sep 16, 2019

@msullivan Do you know what the process for getting this merged is? I don't seem to be able to request a review from a maintainer

@JukkaL
JukkaL approved these changes Sep 16, 2019
Copy link
Collaborator

JukkaL left a comment

Looks good now, thanks for the update!

@JukkaL JukkaL merged commit 8782ae7 into python:master Sep 16, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ckarnell ckarnell deleted the ckarnell:issue-7478 branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.