Fix issue 7478 #7504
Merged
Fix issue 7478 #7504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I'd say we should just remove the |
|
Otherwise looks great |
|
Went ahead and removed "a" and fixed related tests. |
|
@msullivan Do you know what the process for getting this merged is? I don't seem to be able to request a review from a maintainer |
JukkaL
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this issue: #7478
I reused an existing error message, but noticed it has a grammatical error where it uses the word "a", but in this case should use the word "an". I considered just removing "a", and decided against it because it would break other tests. Happy to change this error message if needed.