Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove new_semantic_analyzer from config parameters #7529

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Remove new_semantic_analyzer from config parameters #7529

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
542f02b
Remove new_semantic_analyzer from config parameters
onlined Sep 18, 2019
f1dc856
Change string comparison to member comparison
onlined Sep 19, 2019
301c63e
Change member comparison to string comparison again
onlined Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion mypy/config_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,12 @@ def parse_section(prefix: str, template: Options,
if key in config_types:
ct = config_types[key]
else:
dv = getattr(template, key, None)
dv = None
# We have to keep new_semantic_analyzer in Options
# for plugin compatibility but it is not a valid option anymore.
assert hasattr(template, 'new_semantic_analyzer')
if key != 'new_semantic_analyzer':
dv = getattr(template, key, None)
if dv is None:
if key.endswith('_report'):
report_type = key[:-7].replace('_', '-')
Expand Down