Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support environment variable interpolation for junit_xml + quickstart_file config keys #8479

Merged
merged 2 commits into from Mar 6, 2020
Merged

Conversation

Mattwmaster58
Copy link
Contributor

@Mattwmaster58 Mattwmaster58 commented Mar 3, 2020

Expands on the goal of #7273
Exactly what the title says. The docs say this:

Some flags support user home directory and environment variable expansion. To refer to the user home directory, use ~ at the beginning of the path. To expand environment variables use $VARNAME or ${VARNAME}.

This would add quickstart_file and junit_xml to the flags that support environment variable expansion.

The only downside I see here is if someone decides they want their JUnit XML ouput file or quickstart file something weird like $file

@Mattwmaster58 Mattwmaster58 changed the title Support environment variable interpolation for junit_xml config key Single line change: Support environment variable interpolation for junit_xml config key Mar 3, 2020
@Mattwmaster58 Mattwmaster58 changed the title Single line change: Support environment variable interpolation for junit_xml config key Support environment variable interpolation for junit_xml + quickstart_file config keys Mar 3, 2020
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ilevkivskyi ilevkivskyi merged commit d2e984a into python:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants