[mypyc] Don't free target of LoadMem too early #9299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional reference to the object from which we are reading from to `LoadMem` so that the object won't be freed before we read memory. Fixes mypyc/mypyc#756.
TH3CHARLie
approved these changes
Aug 13, 2020
|
I checked that this fixes the crash with Dropbox internal repositories. |
|
This commit caused https://github.com/mypyc/mypyc-benchmark-results/blob/master/reports/benchmarks/nqueens.md a 6.4% performance downgrade. |
I will look at the generated code to see if there's anything suspicious that might have caused this. Since the benchmark is pretty small, 6.4% could also be just noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional reference to the object from which we are reading from
to
LoadMemso that the object won't be freed before we read memory.Fixes mypyc/mypyc#756.