Add support for next-gen attrs API #9396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. The windows failures seem to be not-related to my diff. Is there some other thing necessary to get this looked at? |
These include the attr class makers: define, mutable, frozen And the attrib maker: field Also includes support for auto_attribs=None which means auto_detect which method of attributes are being used.
euresti
force-pushed
the
attrs_next_gen
branch
from
da57741
to
d2f2774
Compare
|
@ilevkivskyi am I missing anything to get this reviewed? |
msullivan
approved these changes
Nov 18, 2020
|
I'm sorry about the delay here. I'm going to merge this, and I hope we can stay on top of this sort of PR in the future, but if you want to drop the attrs plugin in favor of one maintained inside attrs or alternately add mechanisms for disabling the built-in one in favor of an external one, we can figure out the best way to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds handlers for attr.define, attr.mutable, and attr.frozen.
Adds support for frozen having a non False default.
Adds support the attrib maker: field
Also includes support for auto_attribs=None which means "auto detect which method to use depending on my class".
Test Plan
Added a couple of simple tests.