Use Py_TRASHCAN_{BEGIN,END} in tp_dealloc functions #9839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/python/cpython/blob/master/Include/cpython/object.h#L456 Fixes #789. I didn't add a test because a test needs to create a lot of nodes.
JukkaL
approved these changes
Dec 28, 2020
There was a problem hiding this comment.
Thanks, this was a nasty bug. I assume that there's no easy way to fix this on Python 3.7 and earlier. Maybe we could implement something similar ourselves eventually?
Please add a follow-up issue to write a regression test to cover this case, once we have a way of adding expensive tests that only get run daily, for example.
| @@ -627,8 +627,10 @@ def generate_dealloc_for_class(cl: ClassIR, | |||
| emitter.emit_line('{}({} *self)'.format(dealloc_func_name, cl.struct_name(emitter.names))) | |||
| emitter.emit_line('{') | |||
| emitter.emit_line('PyObject_GC_UnTrack(self);') | |||
| emitter.emit_line('CPy_TRASHCAN_BEGIN(self, {})'.format(dealloc_func_name)) | |||
There was a problem hiding this comment.
Add short description of why we need to do this.
|
This does work on on 3.7, but a new API got introduced in 3.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/python/cpython/blob/master/Include/cpython/object.h#L456
Fixes mypyc/mypyc#789.
I didn't add a test because a test needs to create a lot of nodes.
Tested manually.