PEP 590: Use size_t for "number of arguments + flag" #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitwise operations are not well defined on signed values in C.
|
What about changing the name |
|
I think it should be In all other places, CPython uses |
That's a cosmetic issue, I'm fine leaving it to the implementation/documentation.
OK, sure. I don't care much either way.
The conflict should be trivial to solve. |
jdemeyer
approved these changes
May 21, 2019
Changing the frame API semantics based on whether or not a tracing function is active is tricky to implement and hard to document clearly, so this simplifies the proposal by instead having the frame API always expose a write-through proxy at function scope, and restricting the dynamic snapshot behaviour to the locals() builtin.
…ython#1069) - new design discussion section to cover the requirement that the semantics of locals() itself at function scope be left alone - propose a C level API that exactly matches Python level frame.f_locals semantics - other minor text formatting and wording updates
* Fix markup for wave section * Add estimated EOL for 3.9 * mention pynntp and why getopt and wave stay * Add Ned's suggestion
In the Steering Council discussions leading up to the [2019-04-26 update], I was appointed BDFL delegate for PEPs 576, 579, 580, and 590. PEP 590 was still just a draft on the mailing list when the SC updated the PEPs themselves, so it wasn't updated then. [2019-04-26 update]: https://github.com/python/steering-council/blob/master/updates/2019-04-26_steering-council-update.md#peps
As discussed on the typing-sig mailing list, the currently specified behavior for `# type: ignore` on a line by itself has remained mostly unimplemented and doesn't seem useful. Instead, the PEP now mandates a syntax for ignoring all errors in a specific file, which is more obviously useful. I considered adding a sentence like "Individual type checkers may add additional syntax for silencing errors", but it didn't seem particularly useful since type checkers in general are free to add extensions to what PEP 484 specifies. While I was at it I added a reference to PEP 526 to an out-of-date sentence adjacent to the modified paragraph.
* Add my initial draft * PEP 593: update PEP structure and add content. * PEP 593: Push updates * PEP 593: expand the "Improving Roundup" section and move it to the top. * PEP 593: expand the "Roundup advantages" and "Migration considerations" sections. * PEP 595 (was 593): expand and reword some sections. * PEP 595: rename file * PEP 595: remove Discussion-To header, fix formatting of Author header.
Co-Authored-By: Jelle Zijlstra <jelle.zijlstra@gmail.com>
* Add "Experimental Multi-Phase Initialization API" section * Add PyPreConfig._config_init private field. * Rename PyInitError to PyStatus. * Rename PyInitError_Failed() to PyStatus_Exception() * Rename Py_ExitInitError() to Py_ExitStatusException() * Fix Python Configuration default values: isolated=0 and use_environment=1, instead of -1. * Document isolated field and #ifdef MS_WINDOWS * Define path conf function
* Fix _init_main=0 example: set config._init_main to 0! * Document special builds needed by some speficic options like show_alloc_count. * Specify that preconfiguration only requires command line arguments for the "Python Configuration" (not for "Isolated Configuration").
* changed refrained to referred * changed cooperate to corporate
* PEP 594: deprecate telnetlib * PEP 594: Deprecate email compat32 APIs * Add 'added in' years to table * Reference other PEPs, update sections for cgi and audio mods * Fix typo and table entries (thanks Jelle and Brett)
|
Can this be merged please? |
|
Mark seems unavailable – he did not reply to my ping about this PR, but was active on Python-dev. |
|
This turned out to look quite messy on GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C, bitwise operations are much better defined on unsigned values.
Since we do
nargs & ~PY_VECTORCALL_ARGUMENTS_OFFSET, we should do it on an unsigned value.cc @jdemeyer @markshannon