Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 621: Try to simplify the motivation section #1469

Merged
merged 6 commits into from Jun 26, 2020

Conversation

brettcannon
Copy link
Member

No description provided.

Copy link
Sponsor Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only some grammar nits.

pep-0621.rst Outdated Show resolved Hide resolved
pep-0621.rst Outdated Show resolved Hide resolved
pep-0621.rst Outdated Show resolved Hide resolved
pep-0621.rst Outdated Show resolved Hide resolved
pep-0621.rst Outdated Show resolved Hide resolved
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me likey. All of @di's suggestions look good to me! ^.^

brettcannon and others added 5 commits June 26, 2020 11:02
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
Co-authored-by: Dustin Ingram <di@users.noreply.github.com>
@brettcannon brettcannon merged commit 1fa2817 into python:master Jun 26, 2020
@brettcannon brettcannon deleted the pep-621-simplify-motivation branch June 26, 2020 18:12
AA-Turner pushed a commit to AA-Turner/peps that referenced this pull request Aug 15, 2020
mnm678 pushed a commit to mnm678/peps that referenced this pull request Oct 22, 2020
gaborbernat pushed a commit to gaborbernat/peps that referenced this pull request Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants