PEP 639: edits from review #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
@di Thank you ++ .. I made a few suggestions myself that you may want to merge in.
Co-authored-by: Philippe Ombredanne <pombredanne@gmail.com>
|
@pombredanne Done! Thanks! |
|
@python/pep-editors dear editors, it would be great if you could merge this PR at this stage. |
JelleZijlstra
approved these changes
Sep 30, 2020
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
@JelleZijlstra Thanks! |
mnm678
pushed a commit
to mnm678/peps
that referenced
this pull request
Oct 22, 2020
* Fix monospaces * The 'license expression' term shouldn't be monospaced/capitalized * Rephrasing * Fix capitalization of titles * Make it clear when we're talking about the Classifiers field vs classifiers * More monospace fixes * Edits for clarity * Fix 'License ::' prefix * Update link * More tweaks for clarity * Fix broken ref Co-authored-by: Philippe Ombredanne <pombredanne@gmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
gaborbernat
pushed a commit
to gaborbernat/peps
that referenced
this pull request
Dec 13, 2020
* Fix monospaces * The 'license expression' term shouldn't be monospaced/capitalized * Rephrasing * Fix capitalization of titles * Make it clear when we're talking about the Classifiers field vs classifiers * More monospace fixes * Edits for clarity * Fix 'License ::' prefix * Update link * More tweaks for clarity * Fix broken ref Co-authored-by: Philippe Ombredanne <pombredanne@gmail.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cc @pombredanne)