Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 639: Update PEP delegate, post history and CODEOWNERS #2228

Merged
merged 2 commits into from Jan 20, 2022

Conversation

CAM-Gerlach
Copy link
Member

Update the PEP delegate for PEP 639, pending an approving outcome of the relevant PyPA committers discussion. Also updates the post history.

@JelleZijlstra
Copy link
Member

CI failure looks spurious (something on GitHub's side is down).

@CAM-Gerlach
Copy link
Member Author

Not sure what's going on with the checks; everything builds fine locally. Looks like a transient GH Actions network error.

@CAM-Gerlach
Copy link
Member Author

@CAM-Gerlach
Copy link
Member Author

Looks like its fixed. @JelleZijlstra , can you re-run?

@JelleZijlstra
Copy link
Member

All green now.

@CAM-Gerlach
Copy link
Member Author

Thanks, standby on this for a week or so until the discussion runs its course. @pfmoore how long should we wait, assuming no complications?

@ofek
Copy link
Sponsor Contributor

ofek commented Jan 13, 2022

Quite a few approvals already

@pfmoore
Copy link
Member

pfmoore commented Jan 13, 2022

A PyPA vote is 7 days, so I'm planning on waiting till next Tuesday

@CAM-Gerlach CAM-Gerlach marked this pull request as ready for review January 20, 2022 01:44
@CAM-Gerlach
Copy link
Member Author

Hey @pfmoore and @brettcannon , are we okay to merge this now, given its been 8 days, no one has objected and everyone who did speak up approved?

@CAM-Gerlach CAM-Gerlach requested a review from a team as a code owner January 20, 2022 04:46
@CAM-Gerlach CAM-Gerlach changed the title PEP 639: Update PEP delegate (and post history) PEP 639: Update PEP delegate, post history and CODEOWNERS Jan 20, 2022
@CAM-Gerlach CAM-Gerlach self-assigned this Jan 20, 2022
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; it's been a week and there were no objections on the linked thread. Your call on whether to wait for additional confirmation from Paul.

@@ -493,7 +493,7 @@ pep-0635.rst @brandtbucher @gvanrossum
pep-0636.rst @brandtbucher @gvanrossum
pep-0637.rst @stevendaprano
pep-0638.rst @markshannon
pep-0639.rst @pfmoore
pep-0639.rst @pfmoore @CAM-Gerlach
Copy link
Member

@AA-Turner AA-Turner Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a pedantic reading of PEP 1, I don't think PEP editors are allowed to be listed in CODEOWNERS.

Update .github/CODEOWNERS [7] such that any core developer co-author(s) or sponsor are listed for your new file such that any future pull requests will be assigned to them.

A PEP editor can be a sponsor, but the case of PEP editors being authors seems to be missed as an edge case.

However, I think it makes sense for PEP editors to be listed here, so probably better to update PEP 1 to allow this? If other @python/pep-editors agree I could propose an update the affected lines.

A

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'm already listed as the owner of PEPs 673 and 675 and I'm not a core dev, so in practice we're not following this rule already. Let's amend PEP 1 to make it clear. I'd suggest wording like "any author or sponsor with write access to the PEPs repository".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2252

A

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that certainly seems like a clear oversight to me; PEP 1 may not have envisioned PEP editors who weren't core developers, like you, me and @JelleZijlstra are today—and it affects you too on your PEP 676, since you're the author but not a sponsor either.

@pfmoore
Copy link
Member

pfmoore commented Jan 20, 2022

Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants