Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 625: Update following discussions #2671

Merged
merged 5 commits into from Jul 9, 2022
Merged

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Jun 25, 2022

Change the proposed naming conventions based on the latest discussions on Discourse.

@pfmoore
Copy link
Member Author

pfmoore commented Jun 25, 2022

Apparently, I can't add @uranusjr as a requested reviewer 🙁

@uranusjr - could you review anyway, please?

pep-0625.rst Outdated Show resolved Hide resolved
pep-0625.rst Outdated Show resolved Hide resolved
pep-0625.rst Outdated Show resolved Hide resolved
pep-0625.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
pep-0625.rst Outdated Show resolved Hide resolved
Co-authored-by: Davide Rizzo <sorcio@gmail.com>
Copy link
Contributor

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing I noticed is we use both filename and file name (both your text and mine) in the text and it may be worthwhile to unify the spelling.

@pfmoore
Copy link
Member Author

pfmoore commented Jul 9, 2022

"Filename" had marginally more uses, so I've standardised on that version.

@pfmoore pfmoore merged commit 43782e9 into python:main Jul 9, 2022
@pfmoore pfmoore deleted the pep625_update branch July 9, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants