Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Test Python 3.11 beta #2727

Merged
merged 5 commits into from
Jul 31, 2022
Merged

Infra: Test Python 3.11 beta #2727

merged 5 commits into from
Jul 31, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 22, 2022

Due to the recent delays in the 3.11 beta, it's very important to test it as widely as possible to help find issues before RC1.

https://discuss.python.org/t/the-cursed-release-of-python-3-11-0b4-is-now-available/17274?u=hugovk


Because we have test warnings turned into errors, temporarily ignore these in dependencies:

Also skip testing 3.11 on Windows because lxml isn't yet available.

@hugovk hugovk added the infra Core infrastructure for building and rendering PEPs label Jul 22, 2022
@hugovk hugovk requested review from CAM-Gerlach, AA-Turner and a team as code owners July 22, 2022 11:54
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we're doing this; thanks @hugovk . A couple comments, one small and one not so small...

.github/workflows/render.yml Outdated Show resolved Hide resolved
.github/workflows/render.yml Outdated Show resolved Hide resolved
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@CAM-Gerlach
Copy link
Member

Alternatively, it might be better to just use the matrix for the test workflow, since its purpose is the test any build system changes, whereas the render job runs on every PR and push that's mostly just PEP content updates, so it would substantially increase CI load (and the probability of random failures) for relatively little gain there, no?

@hugovk
Copy link
Member Author

hugovk commented Jul 22, 2022

Where projects may often test with pre-release Pythons, they rarely build docs, so building docs is a good way to increase coverage of neglected code paths.

That's how I found a release blocker for 3.11 (and a non-blocker too) :)

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Jul 22, 2022

Sure, I'm just suggesting only running the dev Python matrix job to build the PEPs with Sphinx when the test workflow is triggered, i.e. when some sort of infra-related change is made, rather than on every PR and push. The frequency of PEP infra changes is still typically substantially higher than that of CPython beta releases, and that avoids 1-2 orders of magnitude of extra CI bandwidth, and the main author-facing CIs suddenly starting to fail inexplicably (to authors) on PRs and main when a new CPython beta version is released, as opposed to on PEP editor/infra contributor PRs where it can be recognized and dealt with properly.

Copy link
Member Author

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra: update JamesIves/github-pages-deploy-action

(Edit: oops, this was meant to be the batch commit comment, the two buttons are right next to each other!)

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, thought I'd approved this! LGTM, thanks @hugovk

FYI, we could also just use @v4 now with the GitHub pages action like we do with the others, if we didn't want to have to be bumping the version manually all the time.

@hugovk
Copy link
Member Author

hugovk commented Jul 31, 2022

Good idea, done!

@hugovk hugovk merged commit 8af617d into python:main Jul 31, 2022
@hugovk hugovk deleted the add-3.11 branch July 31, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants