Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 717: Delegated Repository Authentication #3172

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dstufft
Copy link
Member

@dstufft dstufft commented Jun 12, 2023

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
    • General topic has been discussed throughout many issue trackers over the years. This specific PEP was not, but have reached out to stakeholders in various projects, with no concerns about the design.
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--3172.org.readthedocs.build/pep-0717/

@dstufft dstufft requested a review from a team as a code owner June 12, 2023 03:48
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
pep-0717.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@dstufft
Copy link
Member Author

dstufft commented Jun 12, 2023

Applied suggestions, thanks!

@CAM-Gerlach CAM-Gerlach self-requested a review June 13, 2023 00:40
@CAM-Gerlach CAM-Gerlach added the new-pep A new draft PEP submitted for initial review label Jun 13, 2023
@CAM-Gerlach
Copy link
Member

Sorry for the delay—I ended up having way too much on my plate to review this today, but I'll get to it tomorrow (er, later today by this point 😆 )

@AA-Turner
Copy link
Member

@dstufft is this PEP ready to merge as an initial draft?

A

pep-0717.rst Outdated Show resolved Hide resolved
AA-Turner and others added 2 commits August 25, 2023 05:03
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@JelleZijlstra
Copy link
Member

@dstufft anything blocking this from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants