Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 448: Fix misleading passage in the abstract #3573

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

MrMino
Copy link
Contributor

@MrMino MrMino commented Dec 8, 2023

The passage in the PEP misleads its readers into believing, that unpacking in comprehensions is supported. This is not the case, as presented by the abstract itself:

This PEP does not include unpacking operators inside list, set and dictionary comprehensions although this has not been ruled out for future proposals.

See discussion in https://discuss.python.org/t/pep-448-contradictory-abstract/40657/6


馃摎 Documentation preview 馃摎: https://pep-previews--3573.org.readthedocs.build/

@MrMino MrMino requested a review from a team as a code owner December 8, 2023 22:30
Copy link

cpython-cla-bot bot commented Dec 8, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@Rosuav
Copy link
Contributor

Rosuav commented Dec 8, 2023

Saw this mentioned on Discourse, and I broadly agree, but I would be inclined to do the edit at the end of the abstract instead - it looks like maybe that sentence is left over from an earlier edit, possibly.

Would like to get input from the PEP author here.

peps/pep-0448.rst Outdated Show resolved Hide resolved
peps/pep-0448.rst Outdated Show resolved Hide resolved
@CAM-Gerlach
Copy link
Member

Would like to get input from the PEP author here.

@Veedrac ?

@gvanrossum
Copy link
Member

gvanrossum commented Dec 9, 2023

I approve of fixing this (using either the OP's wording or CAM's suggestion). It seems this was an oversight introduced when (in commit 401c977) I accepted most of the original PEP but rejected unpacking in compehensions and generator expressions. I simply failed to update that sentence in the opening paragraph of the Abstract.

The passage in the PEP misleads its readers into believing, that
unpacking in comprehensions is supported. This is not the case, as
presented by the abstract itself:

> This PEP does not include unpacking operators inside list, set and
> dictionary comprehensions although this has not been ruled out for
> future proposals.
@gvanrossum gvanrossum merged commit c15cbba into python:main Dec 11, 2023
6 checks passed
@Veedrac
Copy link

Veedrac commented Dec 11, 2023

@CAM-Gerlach You have my retroactive endorsement.

@MrMino MrMino deleted the pep-448-abstract-edit branch December 12, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants