Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 709: Mark as Final #3591

Merged
merged 1 commit into from
Dec 15, 2023
Merged

PEP 709: Mark as Final #3591

merged 1 commit into from
Dec 15, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 15, 2023

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive (or canonical-pypa-spec, for packaging PEPs)

Helps #2872.

PEP 709 was implemented in Python 3.12, we should mark it as Final so it's no longer listed under Accepted PEPs (accepted; may not be implemented yet).

Should this have a .. canonical-doc:: banner at the top to link to canonical docs?

For example, compare https://peps.python.org/pep-0634/

All I could find in the CPython docs is the What's New entry, but perhaps as an internal change, "canonical docs" doesn't apply in this instance?


📚 Documentation preview 📚: https://pep-previews--3591.org.readthedocs.build/

@hugovk hugovk requested a review from carljm as a code owner December 15, 2023 09:29
@carljm
Copy link
Member

carljm commented Dec 15, 2023

I don't think canonical docs applies, since it's an internal implementation detail with only a few user-visible edge cases.

Thanks for doing this update!

@carljm carljm merged commit a1e9171 into python:main Dec 15, 2023
7 checks passed
@hugovk hugovk deleted the pep709-mark-as-final branch December 15, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants