Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 723: Modify the spec based on post-acceptance discussions #3601

Merged
merged 10 commits into from
Dec 22, 2023

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Dec 21, 2023

TODO: Review and fix hyperlinks


📚 Documentation preview 📚: https://pep-previews--3601.org.readthedocs.build/

peps/pep-0723.rst Outdated Show resolved Hide resolved
peps/pep-0723.rst Outdated Show resolved Hide resolved
peps/pep-0723.rst Outdated Show resolved Hide resolved
peps/pep-0723.rst Outdated Show resolved Hide resolved
peps/pep-0723.rst Outdated Show resolved Hide resolved
peps/pep-0723.rst Outdated Show resolved Hide resolved
@hugovk
Copy link
Member

hugovk commented Dec 21, 2023

Please also add https://discuss.python.org/t/40418 to the Post-History header, and any other relevant threads.

pfmoore and others added 8 commits December 21, 2023 16:09
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@pfmoore
Copy link
Member Author

pfmoore commented Dec 22, 2023

I'll leave this for a few days in draft mode in case @ofek wants to add any comments before I mark it as ready.

Copy link
Sponsor Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pfmoore pfmoore marked this pull request as ready for review December 22, 2023 16:09
@brettcannon
Copy link
Member

@pfmoore did you need anything from me? Otherwise, as a core dev you can merge the change yourself.

@pfmoore
Copy link
Member Author

pfmoore commented Dec 22, 2023

@brettcannon Nope, I just got distracted and didn't get round to merging 🙂

@pfmoore pfmoore merged commit 5f20094 into python:main Dec 22, 2023
6 checks passed
@pfmoore pfmoore deleted the pep-723-changes branch December 22, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants