Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 11: Make unsupporting a platform less draconian #3633

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Jan 24, 2024

This loosens the statements about builds and configure needing to Break and instead changes this to a mere build/configure time warning. This is in line with how we treat platforms that are not on a support Tier (of which there are many). Doing anything else would basically be unreasonable punshiment for anything in our support Tiers that then loses its official PEP-11 support for whatever reason.

Discuss this change in https://discuss.python.org/t/proposed-update-to-pep-11-on-unsupporting-a-platform-less-draconian-measures/44065


📚 Documentation preview 📚: https://pep-previews--3633.org.readthedocs.build/

This loosens the statements about builds and configure needing to
Break and instead changes this to a mere build/configure time warning.
This is in line with how we treat platforms that are not on a support
Tier (of which there are many).  Doing anything else would basically
be unreasonable punshiment for anything in our support Tiers that then
loses its official PEP-11 support for whatever reason.
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments, agree with the idea

peps/pep-0011.rst Show resolved Hide resolved
peps/pep-0011.rst Outdated Show resolved Hide resolved
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... with Jelle's suggestions.

@hugovk hugovk changed the title PEP-11: Make unsupporting a platform less draconian PEP 11: Make unsupporting a platform less draconian Jan 25, 2024
@gpshead gpshead marked this pull request as ready for review February 1, 2024 19:26
@gpshead gpshead enabled auto-merge (squash) February 1, 2024 19:27
@gpshead gpshead merged commit 0caaa5a into python:main Feb 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants