Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 695: Mark as Final #3675

Merged
merged 3 commits into from
Feb 17, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 15, 2024

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Helps #3579 and #2872.


馃摎 Documentation preview 馃摎: https://pep-previews--3675.org.readthedocs.build/

@JelleZijlstra
Copy link
Member

This also needs to point to runtime docs (as it involved a major grammar change). Maybe https://docs.python.org/3/reference/compound_stmts.html#type-params and https://docs.python.org/3/reference/simple_stmts.html#type.

@JelleZijlstra
Copy link
Member

@hugovk
Copy link
Member Author

hugovk commented Feb 15, 2024

Thanks, updated! And thanks to the original authors of those sections for already adding the ref anchors! :)

@JelleZijlstra
Copy link
Member

Thanks! Thinking about it some more, maybe we should also link to the typing spec about the type statement? https://typing.readthedocs.io/en/latest/spec/aliases.html#type-statement

cc @erictraut too

@JelleZijlstra JelleZijlstra merged commit 16c8775 into python:main Feb 17, 2024
6 checks passed
@hugovk hugovk deleted the pep695-mark-as-final branch February 17, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants