Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 741: Add sys.get_config_names() #3686

Merged
merged 7 commits into from
Mar 8, 2024
Merged

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 22, 2024

  • Add sys.get_config_names() function.
  • Add PyInitConfig_HasOption() function.
  • Remove Py_ExitWithInitConfig() function.
  • Add "Fully remove the preinitialization" section.
  • Mention when the caller must hold the GIL.
  • Add example increasing an initialization configuration option.
  • "Usage of the stable ABI" section: add more quotes.
  • Document that options side effects are not taken in account by PyInitConfig_Set*() functions.

馃摎 Documentation preview 馃摎: https://pep-previews--3686.org.readthedocs.build/

* Add sys.get_config_names() function.
* Add PyInitConfig_HasOption() function.
* Remove Py_ExitWithInitConfig() function.
* Add "Fully remove the preinitialization" section.
* Mention when the caller must hold the GIL.
* Add example increasing an initialization configuration option.
* "Usage of the stable ABI" section: add more quotes.
* Document that options side effects are not taken in
  account by PyInitConfig_Set*() functions.
@vstinner vstinner requested a review from a team as a code owner February 22, 2024 12:03
@vstinner vstinner marked this pull request as draft February 22, 2024 12:03
@hugovk
Copy link
Member

hugovk commented Feb 22, 2024

A couple of typos:

peps/pep-0741.rst:163: versionned ==> versioned
peps/pep-0741.rst:283: everytime ==> every time

https://github.com/python/peps/actions/runs/8004128585/job/21860885594

@JelleZijlstra
Copy link
Member

Also seems like you need to add a CODEOWNERS entry for this PEP.

@vstinner
Copy link
Member Author

@hugovk:

peps/pep-0741.rst:163: versionned ==> versioned
peps/pep-0741.rst:283: everytime ==> every time

Fixed.

@JelleZijlstra:

Also seems like you need to add a CODEOWNERS entry for this PEP.

Oops right, added!

@vstinner
Copy link
Member Author

PR created to address requests in the discussion: https://discuss.python.org/t/pep-741-python-configuration-c-api-second-version/45403/21

@vstinner vstinner marked this pull request as ready for review March 8, 2024 14:34
@vstinner vstinner requested a review from hugovk as a code owner March 8, 2024 14:34
@vstinner vstinner merged commit 7e7296b into python:main Mar 8, 2024
6 checks passed
@vstinner vstinner deleted the pep741_update branch March 8, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants