Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 2026: Calendar versioning for Python #3834

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jun 11, 2024

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

📚 Documentation preview 📚: https://pep-previews--3834.org.readthedocs.build/pep-2026/

@hugovk hugovk added the new-pep A new draft PEP submitted for initial review label Jun 11, 2024
@hugovk hugovk requested a review from a team as a code owner June 11, 2024 06:47
peps/pep-2026.rst Outdated Show resolved Hide resolved
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of minor nits (mostly regarding using the conditional tense consistently), but LGTM!

peps/pep-2026.rst Outdated Show resolved Hide resolved
peps/pep-2026.rst Outdated Show resolved Hide resolved
peps/pep-2026.rst Outdated Show resolved Hide resolved
peps/pep-2026.rst Outdated Show resolved Hide resolved
peps/pep-2026.rst Show resolved Hide resolved
peps/pep-2026.rst Outdated Show resolved Hide resolved
peps/pep-2026.rst Show resolved Hide resolved
peps/pep-2026.rst Outdated Show resolved Hide resolved
peps/pep-2026.rst Outdated Show resolved Hide resolved
peps/pep-2026.rst Outdated Show resolved Hide resolved
hugovk and others added 3 commits June 12, 2024 15:29
@hugovk hugovk merged commit c8eac39 into python:main Jun 14, 2024
6 checks passed
@hugovk hugovk deleted the pep2026-calver branch June 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pep A new draft PEP submitted for initial review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants