PEP 572: Mention the two minor changes in the Abstract #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks okay to me. 👍 |
vstinner
reviewed
Jul 13, 2018
|
|
||
| expression using the notation ``NAME := expr``. A new exception, | ||
| ``TargetScopeError`` is added, and there is one change to evaluation | ||
| order. |
There was a problem hiding this comment.
I would prefer to be more specific for "evaluation order", like "change to evaluation order of dict comprehension". Otherwise, people might be scared of a bigger change, whereas it's really a minor change ;-)
There was a problem hiding this comment.
Well let them be scared. The abstract is not the place to repeat the spec. The evaluation order change has its own section in the ToC so it's easy to find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #737
Added sentence to Abstract, as requested in #737 (comment) by @gvanrossum.