Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

Staging settings change #132

Closed
frankwiles opened this issue Jul 23, 2014 · 3 comments
Closed

Staging settings change #132

frankwiles opened this issue Jul 23, 2014 · 3 comments

Comments

@frankwiles
Copy link
Member

Need to adjust Django's cookie domains on staging to be:

CSRF_COOKIE_DOMAIN = 'staging.python.org'
SESSION_COOKIE_DOMAIN = 'staging.python.org'

Otherwise we can't login to staging to poke at changes before releasing. Thanks!

@benjaminp
Copy link
Contributor

Won't the staging.python.org cookies be properly set on staging.python.org properly without specifying a domain in the cookie?

@frankwiles
Copy link
Member Author

Unfortunately no, the issue is that by default it gets set to the root of the domain (i.e. '.python.org') so CSRF and SESSION cookies between www. and staging. seem to be conflicting with each other.

So actually for completeness sake we probably want www to be setting those two as 'www.python.org' as well.

@benjaminp
Copy link
Contributor

Okay. Maybe you can submit a PR?

On Thu, Jul 24, 2014, at 08:44, Frank Wiles wrote:

Unfortunately no, the issue is that by default it gets set to the root of
the domain (i.e. '.python.org') so CSRF and SESSION cookies between www.
and staging. seem to be conflicting with each other.

So actually for completeness sake we probably want www to be setting
those two as 'www.python.org' as well.


Reply to this email directly or view it on GitHub:
#132 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants