Use tomllib/tomli over toml
#284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Apr 30, 2023
Comment on lines
-7
to
-18
| packaging==21.3 | ||
| packaging==23.1 | ||
| # via -r requirements.in | ||
| psutil==5.9.0 | ||
| psutil==5.9.5 | ||
| # via | ||
| # -r requirements.in | ||
| # pyperf | ||
| pyparsing==3.0.8 | ||
| # via packaging | ||
| pyperf==2.6.0 | ||
| # via -r requirements.in | ||
| toml==0.10.2 | ||
| # via -r requirements.in |
There was a problem hiding this comment.
I ran pip-compile to regenerate this file, and it also bumped packaging and psutil. Not sure if that's desirable or if I did something wrong there! Not had much experience using pip-compile.
corona10
reviewed
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tomliis more actively maintained thantoml, is more up to date with the TOML spec, and has been incorporated into the Python stdlib astomllibin Python 3.11.I think this is worth doing anyway, but this also helps with #282, as
tomliis apy.typedpackage that ships with inline type annotations.