tornado: use WindowsSelectorEventLoopPolicy() with Python 3.8 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested changes
Jul 29, 2019
|
cc @methane |
Python 3.8 changed the default event loop to ProactorEventLoop which doesn't implement everything required by tornado and breaks the benchmark. This makes WindowsSelectorEventLoop the default again like suggested in: tornadoweb/tornado#2686 Limit to 3.8 only in the hopes that the new event loop supports the required methods with 3.9. Fixes python#61
lazka
force-pushed
the
tornado-force-win-event-loop
branch
from
b87917f
to
d8cd178
Compare
|
Thanks. I merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 changed the default event loop to ProactorEventLoop which doesn't
implement everything required by tornado and breaks the benchmark.
This makes WindowsSelectorEventLoop the default again like suggested in:
tornadoweb/tornado#2686
Limit to 3.8 only in the hopes that the new event loop supports the required
methods with 3.9.
Fixes #61