Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyphenation in Chrome #54

Closed
wants to merge 1 commit into from
Closed

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 16, 2020

There's a bug or two in Chromium (e.g. Chrome, Opera) such that the Lucida Grande font doesn't hyphenate properly (with hyphens: auto) which makes things harder to read.

This shows up on macOS, which has this this font, but not on Android or Windows, which use the fallback Arial. Firefox and Safari are okay.

This affects at least docs.python.org and pip.pypa.io, and both use this theme.

Before

Here's an example from https://pip.pypa.io/en/stable/development/release-process/ in newest Chrome 85 on macOS Mojave:

docs1

(Created with sphinx-quickstart using the defaults, changing html_theme = 'alabaster' to 'python_docs_theme', putting some pip text in index.rst and running rm -rf _build; make html: sphinx-test2.zip.)

After

This PR suggests to ditch Lucida Grande, at least until when and if the Chrome bug is fixed and widely deployed. This would also make it consistently use Arial as on non-Macs:

docs2


See also my original PR at pypa/pip#8879 to disable hyphens: auto, but they'd prefer to fix the upstream theme.

@hugovk
Copy link
Member Author

hugovk commented Oct 24, 2020

Closing this, Chrome has now fixed this in Canary 88.0.4300.0!

I've confirmed it working for https://pip.pypa.io/en/stable/development/release-process/ in Canary Version 88.0.4301.0 (Official Build) canary (x86_64) on macOS (and still repro on older Chrome 86).

Chrome 88 is due out on 2021-01-19: https://www.chromestatus.com/features/schedule

@hugovk hugovk closed this Oct 24, 2020
@hugovk hugovk deleted the fix-mac-chrome-font branch October 24, 2020 07:49
@JulienPalard
Copy link
Member

Did not commented before, because I have literally no front-end skills, but I'm relieved that we don't have to fix Google bugs our side, it felt wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants