-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated copyright link to license in repo #67
Conversation
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@CAM-Gerlach Thanks again, that was super helpful, and I learned more about Sphinx along the way. I committed your second suggestion and will also submit a PR to add the license URL to the dictionary |
You're welcome, I'm glad! I'm no expert at Sphinx theming either; I know just enough to be dangerous 😆 Looks like its up to @Mariatta for the final review? |
Could you explain how to use it? because with my workflow, it doesn't work.
patch with this diff diff --git a/conf.py b/conf.py
index 4071095..f20b61f 100644
--- a/conf.py
+++ b/conf.py
@@ -95,6 +95,7 @@ pygments_style = 'sphinx'
# Use the upstream python-docs-theme
html_theme = 'python_docs_theme'
html_theme_options = {
+ 'copyright_url': 'https://www.demo.org',
'collapsiblesidebar': True,
'issues_url': 'https://github.com/python/devguide/issues/new',
}
As you can see, I have got Any idea? Thank you |
Thanks @matrixise . This PR neglected to add
in |
In fact, without this parameter, the build of the devguide or another project using this PR would generate a Warning with the undefined In this case, the @jablonskidev Could you update your PR with the Thank you |
@matrixise @CAM-Gerlach Thanks for your feedback! I added |
Thanks @jablonskidev I am going to check in few minutes. |
@Mariatta What do you think about this PR, for me, it's fine, and we can merge it. |
@JulienPalard Just to be sure. For you, is there an issue with this PR and the "copyright" link in the existing documentations? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution.
This should fix issues #652 and #653 in the devguide. (The issues are duplicates of each other, so this PR is still addressing only one issue at a time.)