Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate library/string.rst line 94 #723

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Nov 25, 2023

This PR contains the Taiwanese Traditional Chinese (zh-TW) translation of CPython v3.12 library/string.rst:94.

Questions

  • What is the idiomatic translation of "this function/method takes ...", is it "這個 function/method 的引數包括……", or "這個 function/method 接收……"?
  • How do we translate "It's a wrapper [of ...]"?

library/string.po Outdated Show resolved Hide resolved
@rockleona
Copy link
Collaborator

hi @ShamrockLee ,

to your quetions:

  • I think 「接收」 will be better
  • I think "wrapper" can stay in english, since we might not use it in Traditional Chinese frequently

@ShamrockLee ShamrockLee force-pushed the tr-string-94-format branch 2 times, most recently from 60a3864 to 2cce368 Compare November 25, 2023 08:51
library/string.po Outdated Show resolved Hide resolved
@mattwang44
Copy link
Collaborator

rebase

@ShamrockLee
Copy link
Contributor Author

Sorry for the delay. I was busy working on an assignment recently.

I'll address the review suggestions before next sunday.

@mattwang44
Copy link
Collaborator

@ShamrockLee
有時間再處理就好,別感到有壓力 👍🏽

@mattwang44
Copy link
Collaborator

@ShamrockLee
最近要 wrap up 我們 11 月活動的所有 PR 了,想請問你有空來處理這個 PR 嗎?
還是我能否來幫你修正剩下未完成的部分呢?

@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Jan 3, 2024

今天期末剛結束。我處理個。

@ShamrockLee
Copy link
Contributor Author

Rebased on top of event-1125 and resolved merge conflict.

Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@mattwang44 mattwang44 merged commit bd5a3c6 into python:event-1125 Jan 3, 2024
1 check passed
@ShamrockLee ShamrockLee deleted the tr-string-94-format branch January 3, 2024 22:04
mattwang44 pushed a commit that referenced this pull request Jan 26, 2024
mattwang44 pushed a commit that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants