working on ssl #770
Merged
working on ssl #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
一樣請記得確認沒有 PR branch conflict（不用開新的 PR，直接 rebase 這個 branch 就好） |
timmy0123
force-pushed
the
ssl
branch
2 times, most recently
from
e51c316
to
91ee219
Compare
mattwang44
reviewed
Dec 25, 2023
There was a problem hiding this comment.
- 目前你對於 branch 的操作是 merge 不是 rebase，用 merge 也沒有關係（只是 PR review 會比較麻煩）
- 對於 cipher 一詞的翻譯我還是有些疑慮，我開了一個 discussion (cipher 的翻譯 #771)，如果你有任何想法也可以在那邊一起討論（或是之後遇到不確定的詞彙你也可以直接開一個 discussion）
mattwang44
reviewed
Dec 25, 2023
library/ssl.po
Outdated
Comment on lines
151
to
153
| "使用預設內容及 IPv4/IPv6 雙協定堆疊的客戶端 socket 範例：\n" | ||
| "\n" | ||
| "::" |
There was a problem hiding this comment.
- nit: 可以參考 更簡潔的 rst 的 literal block 標記語法 #568
- context 一詞通常不會翻譯成「內容」，以免和 content 混淆，你有覺得哪個翻譯比較適當嗎？
Suggested change
| "使用預設內容及 IPv4/IPv6 雙協定堆疊的客戶端 socket 範例：\n" | |
| "\n" | |
| "::" | |
| "使用預設內容及 IPv4/IPv6 雙協定堆疊的客戶端 socket 範例： ::" |
There was a problem hiding this comment.
目前查樂詞網的翻譯為上下文，只是這邊的context好像是一個新的解釋
https://docs.python.org/3.12/library/ssl.html#ssl.SSLContext
There was a problem hiding this comment.
目前現有翻譯是翻成「情境」（例如 context manager -> 情境管理器，也請見 #400）或「語境」，你覺得合適嗎？
Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
|
提醒一下，如果是在 GitHub UI 上修正 review comment 的話，可以考慮用 |
mattwang44
reviewed
Dec 26, 2023
mattwang44
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.