-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for pypy3.9-v7.3.11 #59
Conversation
Currently, when I run
But 7 months ago, the pypy3.9 job completed successfully: https://github.com/python/pythoncapi-compat/actions/runs/3557936154 on commit 3779f12. Did PyPy 3.9 added PyObject_CallNoArgs() and PyObject_CallOneArg() recently? |
Yeah they were added in 3.9-v7.3.11 and were not present in 3.9-v7.3.10 |
Of course if the older pypy versions are failing with this change, we'll need to have it only take effect for pypy3.9-v7.3.11.. |
Hmm this PR works for me on both 3.9-v7.3.11 & 3.9-v7.3.10.. |
The 3.12-dev CI was broken, I just fixed it: commit 513acb3. Please rebase your PR on top of it. |
Hum, that's annoying. Since it's implemented as a macro in PyPy, what do you think of checking if the macro is already defined or not, rather than checking for PyPy? |
177e992
to
aaefe6d
Compare
yeah that sounds like a better approach, will try now |
aaefe6d
to
a012b0f
Compare
@@ -390,7 +390,7 @@ PyThreadState_LeaveTracing(PyThreadState *tstate) | |||
|
|||
|
|||
// bpo-37194 added PyObject_CallNoArgs() to Python 3.9.0a1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to mention the PyPy version which added support for these functions, here and the same comment below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem, I should have known better than to make changes without commenting them ha
pushed it up there
a012b0f
to
79584d4
Compare
It's kind of sad that PyPy updates requires fixing |
I merged your PR, thanks. |
Python 3.9.16 (feeb267ead3e6771d3f2f49b83e1894839f64fb7, Dec 29 2022, 14:23:21)
PyPy 7.3.11 with GCC 10.2.1 20210130 (Red Hat 10.2.1-11)
Tests run fine on pypy 7.3.11 with those 2 changes
Ran 24 tests in 0.154s
OK
Python 2.7 (release build): 11 C tests succeeded!
Ignore missing Python executable: python3.4
Ignore missing Python executable: python3.5
Ignore missing Python executable: python3.6
Ignore missing Python executable: python3.7
Ignore missing Python executable: python3.8
CPython 3.9 (release build): 11 C tests succeeded!
CPython 3.9 (release build): 11 C++03 tests succeeded!
CPython 3.9 (release build): 11 C++11 tests succeeded!
Ignore missing Python executable: python3.10
Ignore missing Python executable: python3.11
Ignore missing Python executable: python3.12
Ignore missing Python executable: python3-debug
Ignore missing Python executable: pypy
Ignore missing Python executable: pypy2
Ignore missing Python executable: pypy2.7
Ignore missing Python executable: pypy3
Ignore missing Python executable: pypy3.6
Ignore missing Python executable: pypy3.7
Ignore missing Python executable: pypy3.8
Ignore missing Python executable: pypy3.9
PyPy 3.9 (release build): 8 C tests succeeded!
PyPy 3.9 (release build): 8 C++03 tests succeeded!
PyPy 3.9 (release build): 8 C++11 tests succeeded!
Tested: 3 Python executables