Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events Page - Currently ongoing events do not display #2138

Open
sgsabbage opened this issue Sep 18, 2022 · 0 comments · May be fixed by #2167
Open

Events Page - Currently ongoing events do not display #2138

sgsabbage opened this issue Sep 18, 2022 · 0 comments · May be fixed by #2167

Comments

@sgsabbage
Copy link

Describe the bug
Current events do not appear in either Past or Upcoming events on the events page

I believe this is because Upcoming Events uses for_datetime, which searches for events with a start date greater than today, while Past Events ("You just missed...") uses until_datetime which searches for events with an end date less than today.

As such, a multi-day event that is currently ongoing is not picked up by either filter and effectively disappears from the event page until it's finished.

To Reproduce
Steps to reproduce the behavior:

  1. Have an event that starts before today and ends after today
  2. Go to the Events listing page (https://www.python.org/events/python-events/)
  3. The event will not appear

With DjangoCon Europe set for the 21st - 25th of September, and currently showing as an Upcoming Event, this issue should be reproducible between these dates.

Expected behavior
Current events should display somewhere on the events page.

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Version: 105.0.5195.127

Additional context
I'm unsure whether or not currently ongoing events should appear in Past or Upcoming Events, or if there should be a separate category for them, but disappearing completely is probably not ideal, and slightly confusing

@saadmk11 saadmk11 linked a pull request Oct 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant