Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Add Python 3.9 for Windows #147

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Add Python 3.9 for Windows #147

merged 1 commit into from
Oct 24, 2020

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Sep 27, 2020

Not sure if this will works, 3.9 is not yet listed on the indicated page.

Might fix #146 and then also will fix python/mypy#9488

@gvanrossum
Copy link
Member Author

Hm, it looks like we'll have to wait until the official final 3.9.0 release is out. According to https://www.python.org/dev/peps/pep-0596/ that's going to happen around October 5th.

@gvanrossum
Copy link
Member Author

Closing for now. I'll try again in two weeks.

@gvanrossum gvanrossum closed this Sep 27, 2020
@gvanrossum gvanrossum reopened this Oct 6, 2020
@hugovk
Copy link
Member

hugovk commented Oct 6, 2020

Tracking issue for 3.9 on AppVeyor: appveyor/ci#3541

@hoefling
Copy link

@gvanrossum can you please restart the CI? This should work now, even though Appveyor still doesn't support 3.9, the official installers from www.python.org/downloads are already downloadable.

@gvanrossum
Copy link
Member Author

Closing and reopening to restart CI.

@gvanrossum gvanrossum closed this Oct 24, 2020
@gvanrossum gvanrossum reopened this Oct 24, 2020
@hugovk
Copy link
Member

hugovk commented Oct 24, 2020

I think this is okay to merge now:

continuous-integration/appveyor/branch — AppVeyor build failed

This is an old one still showing: "Failed a month ago in 2 hr 3 min"

continuous-integration/appveyor/pr — AppVeyor build succeeded

This one was restarted: "2 hours ago in 16 min 49 sec"

@gvanrossum gvanrossum merged commit 90342f0 into master Oct 24, 2020
@gvanrossum gvanrossum deleted the windows-3.9 branch October 24, 2020 20:34
@gvanrossum
Copy link
Member Author

Honestly this thing seems to be on life support, but I uploaded the Windows wheels it built for 3.9 to PyPI, so all should be good. (If you want 3.9 wheels for Linux, tell me what needs to be done.)

@hauntsaninja
Copy link
Collaborator

Maybe try adding and pushing a tag and then hopefully travis builds the Linux wheels and they all end up in https://console.cloud.google.com/storage/browser/typed-ast
(basing this off of https://github.com/python/typed_ast/blob/master/release_process.md and the YAML)

@gvanrossum
Copy link
Member Author

Okay, I pushed a new tag do-3.9-builds-for-1.4.1. But I really probably should stop being a maintainer here, since I have no idea how anything works. (If you want to help, you probably have to ask @msullivan or @JukkaL for push access to the repo; I can give you access to the PyPI project.)

@hauntsaninja
Copy link
Collaborator

Looks like it worked, the wheels have appeared in https://console.cloud.google.com/storage/browser/typed-ast

@hoefling
Copy link

@gvanrossum thank you for the quick response and the help with publishing the prebuilt windows wheels! Them missing is always more painful as missing the manylinux ones, since installing gcc on any Linux distro is way easier than vc build tools on Windows.

If you want 3.9 wheels for Linux, tell me what needs to be done

Downloading the typed_ast-1.4.1-cp39-cp39-manylinux1_i686.whl and typed_ast-1.4.1-cp39-cp39-manylinux1_x86_64.whl and pushing them to PyPI with twine would complete the task.

@gvanrossum
Copy link
Member Author

Downloading the typed_ast-1.4.1-cp39-cp39-manylinux1_i686.whl and typed_ast-1.4.1-cp39-cp39-manylinux1_x86_64.whl and pushing them to PyPI with twine would complete the task.

Done. I also did the same for typed_ast-1.4.1-cp39-cp39-manylinux2014_aarch64.whl.

Can someone test all these?

@hauntsaninja
Copy link
Collaborator

I can confirm that typed_ast-1.4.1-cp39-cp39-manylinux1_x86_64.whl works, don't know about the rest of them. Thanks for doing this! See y'all again next year, maybe :-)

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 25, 2020

@gvanrossum Thanks for the help with the wheels!

@hauntsaninja I'm happy to give you access to this repo if you are interested. I don't have a ton of context on this project, and any help would be appreciated. I think that we'd want to keep this up-to-date at least until Python 3.10, depending on how much life Python 2 still has in it.

@ethanhs
Copy link
Contributor

ethanhs commented Oct 25, 2020

@gvanrossum I asked a friend of mine to check the AArch64 wheel (since they have an ARM system running at the moment) and it works fine.

@gvanrossum
Copy link
Member Author

@ethanhs Thanks! Sounds like it takes a village... :-)

@hauntsaninja
Copy link
Collaborator

@JukkaL Sure, if I had write access here / on PyPI, I could help with 3.10 :-)

@gvanrossum
Copy link
Member Author

gvanrossum commented Oct 25, 2020 via email

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 26, 2020

@hauntsaninja You now have write access here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to install on Python 3.9 on Windows Error installing on Python 3.9
7 participants