asyncio.BaseEventLoop missing

[toejough]

The current docs say that asyncio.BaseEventLoop is the base class for all asyncio event loops, but this definition is missing from the typeshed stubs for asyncio.

This results in mypy reporting error: Name 'asyncio.BaseEventLoop' is not defined when you check code like def get_or_create_event_loop() -> asyncio.BaseEventLoop.

Verified this class does exist and is callable as asyncio.BaseEventLoop with python 3.5.2:

> python
Python 3.5.2 (default, Jul 28 2016, 21:28:00)
[GCC 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import asyncio
>>> asyncio.BaseEventLoop
<class 'asyncio.base_events.BaseEventLoop'>
>>>

This is with the latest mypy from github, and the latest typeshed as a submodule:

> mypy --version
mypy 0.4.4-dev-72317c32c65cf318883a4c2ebec6ed9e065c2bfd
>

[gvanrossum]

IIRC the PEP (3156) only has AbstractEventLoop. As a wotkaround you can use
that. Does that work?

On Saturday, August 6, 2016, toejough notifications@github.com wrote:

The current docs
https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.BaseEventLoop
say that asyncio.BaseEventLoop is the base class for all asyncio event
loops, but this definition is missing from the typeshed stubs for asyncio
https://github.com/python/typeshed/blob/master/stdlib/3.4/asyncio/__init__.pyi
.

This results in mypy reporting error: Name 'asyncio.BaseEventLoop' is not
defined when you check code like def get_or_create_event_loop() ->
asyncio.BaseEventLoop.

Verified this class does exist and is callable as asyncio.BaseEventLoop
with python 3.5.2:

python
Python 3.5.2 (default, Jul 28 2016, 21:28:00)
[GCC 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)] on darwin
Type "help", "copyright", "credits" or "license" for more information.>>> import asyncio>>> asyncio.BaseEventLoop<class 'asyncio.base_events.BaseEventLoop'>>>>

This is with the latest mypy from github, and the latest typeshed as a
submodule:

mypy --version
mypy 0.4.4-dev-72317c32c65cf318883a4c2ebec6ed9e065c2bfd>

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#452, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACwrMiLZAn3TOenh_ml9jNtNe6fy3Z2Sks5qdHrSgaJpZM4JeRLG
.

--Guido (mobile)

[toejough]

Yes, I am using that and things are working well - thank you!

[gvanrossum]

Ah, so I think the problem here is the CPython docs for asyncio. While PEP 3156 only mentions AbstractEventLoop, the CPython docs only mention BaseEventLoop. I filed http://bugs.python.org/issue27700 to correct the CPython docs. But in the meantime maybe we should export BaseEventLoop as well? Do you have the time and energy to submit a PR for this purpose? (Unfortunately it will have to be pretty much a copy of AbstractEventLoop with all the @abstractmethod decorators taken out).

[toejough]

Sure - I'll make some time to submit a PR this week.

[gvanrossum]

The CPython docs have been fixed to use AbstractEventLoop now. Should we still keep this open?

[toejough]

nope, this can definitely be closed. Sorry I never got around to it myself 👎