Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove freezegun types (not before October 2022) #5842

Closed
hauntsaninja opened this issue Aug 2, 2021 · 2 comments · Fixed by #8867
Closed

Remove freezegun types (not before October 2022) #5842

hauntsaninja opened this issue Aug 2, 2021 · 2 comments · Fixed by #8867
Labels
stubs: removal Pending removal of third-party distributions

Comments

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Aug 2, 2021 •
edited
Loading

Inline types were added in https://github.com/spulec/freezegun/pull/403/files so we should be able to remove types after the next release is made
@srittau srittau added the stubs: removal Pending removal of third-party distributions label Aug 2, 2021
@srittau srittau changed the title Remove freezegun types Remove freezegun types (not before ?) Jan 12, 2022
@srittau srittau mentioned this issue Jan 27, 2022
Closed
@srittau
Copy link
Collaborator

srittau commented Mar 14, 2022

Please note that freezegun 1.2.0, released 2022-03-03 doesn't ship py.typed. While the linked PR does add it, it doesn't add it to the distribution package.

@srittau
Copy link
Collaborator

srittau commented Apr 16, 2022

freezegun 1.2.1, released 2022-03-18, ships py.typed, updating the removal date to "not before October 2022".

@srittau srittau changed the title Remove freezegun types (not before ?) Remove freezegun types (not before October 2022) Apr 16, 2022
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this issue Jun 9, 2022
freezegun: mark as obsolete since 1.2.1
b4e0325 
Linking python#5842
@hauntsaninja hauntsaninja mentioned this issue Jun 9, 2022
Merged
srittau pushed a commit that referenced this issue Jun 9, 2022
@hauntsaninja
freezegun: mark as obsolete since 1.2.1 (#8042)
2cbbb31 
Linking #5842
@AlexWaygood AlexWaygood mentioned this issue Oct 7, 2022
Merged
@staticdev staticdev mentioned this issue Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stubs: removal Pending removal of third-party distributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stubs for freezegun python/typeshed
2 participants
@srittau @hauntsaninja