-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PyYAML to version 6 #6183
Conversation
* Replace Text with str * Replace alias "_Str" with str * Import from collections.abc and re where applicable * Remove Python 2 branches
stubs/PyYAML/METADATA.toml
Outdated
@@ -1,2 +1 @@ | |||
version = "5.4.*" | |||
python2 = true | |||
version = "6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to specify an exact version? pip install 6.0.0
works, and looking at the changelog, bugfix releases will likely be numbered like 6.0.x
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using 6.0.*
won't work, because there is no matching version at the moment. We can update this, once 6.0.1 gets released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following seems to work just fine for me, pip install 'pyyaml==6.0.*'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird. There were problems with using stars for non-existing parts in CI when doing the change to allowing star syntax. I'll try it here.
This introduces a bunch of new stubtest warnings, but they somehow don't occur in CI. Here's this PR, with pyyaml 6.0 (aka pyyaml 6.0.0, both seem to install the same thing):
master with pyyaml 5.4.1:
|
It's because they're allowlisted: https://github.com/python/typeshed/blob/master/stubs/PyYAML/@tests/stubtest_allowlist.txt allowlist dates back to the initial commit, which means they're allowlisted to have CI be green, rather than any especially good reason. |
I'll have a look. |
* Add yaml._yaml and move CParser and CEmitter there. * Add missing functions, classes, and arguments. * Use relative imports in some modules. * Add __all__ to yaml.cyaml. * Remove unnecessary noqa markers. * Update arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, skimmed, seems fine!
No description provided.