Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubs for PyMySQL #631

Closed
jhagerer opened this issue Oct 25, 2016 · 4 comments
Closed

Stubs for PyMySQL #631

jhagerer opened this issue Oct 25, 2016 · 4 comments

Comments

@jhagerer
Copy link

jhagerer commented Oct 25, 2016

Hi together,

I just began generating stubs for PyMySQL. I auto-generated the stuff via mypy/stubgen.py based on Python 3.5 and afterwards modified the .pyi files manually so that mypy doesn't return errors when type checking my small project.

Since I am new to all this I would be glad to hear some feedback about the work and if there's an option to get this included in future versions of typeshed. Moreover I invite everybody to help me to improve the stubs, especially since it's my first contribution.

Here's the repo link:
https://github.com/ghagerer/pymysql_stubs

@gvanrossum
Copy link
Member

To start, we'd like to hear from the original project's authors. Read here: https://github.com/python/typeshed#third_party

@jhagerer
Copy link
Author

I got a permission from here. So what's the next step then?

@gvanrossum
Copy link
Member

Please make a PR for the typeshed repo that adds your stubs to the third_party tree. Depending on whether your stubs are for Python 2, Python 3, or both, they should go into third_party/2.7, third_party/3, or third_party/2and3. Make sure your PR states that it fixes this issue.

jhagerer pushed a commit to jhagerer/typeshed that referenced this issue Nov 1, 2016
Stubs were auto-generated and manually modified using mypy/stubgen.py and Python 3.5. Closes the following ticket:

python#631
@JelleZijlstra
Copy link
Member

third_party/2and3/pymysql exists now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants