Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asyncio] Make create_task work with coroutines only in 3.12 #10177

Merged
merged 14 commits into from
May 14, 2023

Conversation

sobolevn
Copy link
Member

I've decided to start small and change the most obvious cases of Generator usage in asyncio.

Refs #10116

@github-actions

This comment has been minimized.

@JelleZijlstra
Copy link
Member

Would it be better to add an alias that expands to Coroutine only in 3.12 and Coroutine | Generator (plus typevars) in 3.11 and lower?

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 1d8a199 into main May 14, 2023
@AlexWaygood AlexWaygood deleted the create-task-coroutine branch May 14, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants