Remove redundant NoReturn
union in openpyxl
#10819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #8217 (comment)
Unless you think there's documentation/semantic value in keeping the union. kindof like how sometimes we have redundant unions with
![image](https://private-user-images.githubusercontent.com/1350584/271859964-38dce909-2115-4e91-8d81-c33bce9f2f3c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg2NTQ4MzksIm5iZiI6MTcxODY1NDUzOSwicGF0aCI6Ii8xMzUwNTg0LzI3MTg1OTk2NC0zOGRjZTkwOS0yMTE1LTRlOTEtOGQ4MS1jMzNiY2U5ZjJmM2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYxNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MTdUMjAwMjE5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGFlOGE1ZGYyODRlYmEzMGI5MWRiZDRkZmQyYTk1OGJjYTc0N2JiZTdmMDc2ZTBiYzJiMDZjMWIyMzk0NjcxNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.kO2yjn-QZXR68DRPCRUB8F1QsOUy0TkDidnk673Fe5M)
None
orAny
. In which case I'll update the comment to make that obvious. Although pyright/Pylance seem to completely strip it out.Not going with
def tagname(self) -> NoReturn: ...
for the reason listed in the comment.