Fix signature of argparse._VersionAction.__init__ #11715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
commented
Apr 4, 2024
| @@ -355,6 +355,7 @@ _?ctypes.Array._length_ # _length_ is abstract, https://github.com/python/typesh | |||
| _pydecimal.* # See comments in file | |||
| argparse.ArgumentParser.__init__ # stubtest doesn't recognise the runtime default (a class) as being compatible with a callback protocol (the stub annotation) | |||
| argparse.Namespace.__getattr__ # The whole point of this class is its attributes are dynamic | |||
| argparse._VersionAction.__init__ # "help" argument default changed in 3.11+ point releases, remove entry when dropping 3.10 support | |||
There was a problem hiding this comment.
We could instead copy this to the individual version allowlists, but considering this was changed in a point release (and not having it made yet into the Python 3.12 point release used at GitHub), I think it's safer to have it here – at least for now.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Any reason this PR was closed? |
|
Mostly because for some reason I thought this was the only problem in the Python 3.11 update, but there are loads of others that also need to fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11712