Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds stubs for reportlab #12013

Merged
merged 7 commits into from
May 24, 2024
Merged

Adds stubs for reportlab #12013

merged 7 commits into from
May 24, 2024

Conversation

Daverball
Copy link
Contributor

Large parts of this are still baseline stubs, but the higher level platypus API and some of the lib/pdfgen components it depends on are fairly complete and tested against several medium to large codebases of mine.

Docs can be found here: https://docs.reportlab.com/
There's currently no public git repository available for reportlab, so you'll have to install it and get the source that way.
It is still open source under the BSD license, so no worries there.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the size, I've just scanned through it, and didn't compare with the implementation. The notes in stubtest allowlist make sense to me. If it turns out to be too restrictive, we can always loosen our annotations on request.

A few nits below, though.

stubs/reportlab/reportlab/__init__.pyi Outdated Show resolved Hide resolved
stubs/reportlab/reportlab/pdfbase/pdfdoc.pyi Outdated Show resolved Hide resolved
stubs/reportlab/reportlab/platypus/tables.pyi Show resolved Hide resolved

This comment has been minimized.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 1781cde into python:main May 24, 2024
48 checks passed
@Daverball Daverball deleted the reportlab branch May 28, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants