Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker to 7.1.x #12068

Merged
merged 1 commit into from
May 31, 2024
Merged

Update docker to 7.1.x #12068

merged 1 commit into from
May 31, 2024

Conversation

sobolevn
Copy link
Member

Closes #12025

I propose removing the default value from this param, because it is version specific.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
Copy link
Collaborator

srittau commented May 31, 2024

BaseHTTPAdapter also has new method.

@sobolevn
Copy link
Member Author

sobolevn commented May 31, 2024

@srittau it is an override from requests.HTTPAdapter, see its definition class BaseHTTPAdapter(requests.adapters.HTTPAdapter)::

class HTTPAdapter(BaseAdapter):
    def get_connection_with_tls_context(
        self,
        request: PreparedRequest,
        verify: bool | str | None,
        proxies: Mapping[str, str] | None = None,
        cert: tuple[str, str] | str | None = None,
    ) -> ConnectionPool: ...

@srittau srittau merged commit 66c640e into main May 31, 2024
48 checks passed
@srittau srittau deleted the issue-12025 branch May 31, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants