Fixes to ContextManager #1249
Merged
Fixes to ContextManager #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the easier part of python#655. Would it make sense to add a generic typing.ContextManager that exists in any Python version?
Will submit those in a separate PR later
li-dan
pushed a commit
to li-dan/typeshed
that referenced
this pull request
May 22, 2017
* add typing.ContextManager for 3.6+ only This fixes the easier part of python#655. Would it make sense to add a generic typing.ContextManager that exists in any Python version? * update comment * fix argument types for ContextManager.__exit__ * add AsyncContextManager * add @asynccontextmanager * typing.ContextManager now always exists * back out async-related changes Will submit those in a separate PR later * fix import order * AbstractContextManager only exists in 3.6+ * AbstractContextManager -> ContextManager
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Oct 4, 2020
This dates back three years to python#1249 It seems pretty unused in practice, so I think this is fine: https://grep.app/search?q=from%20contextlib%20import%20ContextManager&case=true https://grep.app/search?q=contextlib.ContextManager&case=true
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Oct 4, 2020
This dates back three years to python#1249 It seems pretty unused in practice, so I think this is fine: https://grep.app/search?q=from%20contextlib%20import%20ContextManager&case=true https://grep.app/search?q=contextlib.ContextManager&case=true
srittau
pushed a commit
that referenced
this pull request
Oct 4, 2020
This dates back three years to #1249 It seems pretty unused in practice, so I think this is fine: https://grep.app/search?q=from%20contextlib%20import%20ContextManager&case=true https://grep.app/search?q=contextlib.ContextManager&case=true Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1200 and python/typing#422. Partial fix for #655.
This does the following:
__exit__to be consistent with CPython.