Fix int(Union[str, int])

[Sterbic]

Calling int() over a union of str and int is currently broken. Fixed the types for int.__init__ to solve this and remove __int__ and __float__ from the str class since it doesn't have those methods.

Solves the following case:

from typing import Union

user_id: Union[str, int] = "123"
user_id_str = "123"
user_id_int = 123

print(int(user_id))
print(int(user_id_str))
print(int(user_id_int))

Mypy error: test.py:7: error: Argument 1 to "int" has incompatible type "Union[str, int]"; expected "SupportsInt"

[ambv]

Removal of __float__ and __int__ methods looks good. The other change works around what is apparently a bug in mypy: there's already an overload there with the types you're adding.

class int(SupportsInt, SupportsFloat, SupportsAbs[int]):
    @overload
    def __init__(self, x: SupportsInt = ...) -> None: ...
    @overload
    def __init__(self, x: Union[str, bytes], base: int = ...) -> None: ...

Since the base attribute has a default value, it seems to me int('10') should have always worked. @JukkaL should we go forward with this workaround or file and fix an issue in mypy instead?

[Sterbic]

Ping

[JukkaL]

The mypy issue may take a while to get fixed, so going forward with a workaround seems reasonable. We can make the workaround cleaner by tweaking the signature a bit:

class int(SupportsInt, SupportsFloat, SupportsAbs[int]):
    @overload
    def __init__(self, x: Union[str, bytes, SupportsInt] = ...) -> None: ...
    @overload
    def __init__(self, x: Union[str, bytes], base: int) -> None: ...

Note that there is no default for base, so the overload items aren't overlapping.

[gvanrossum]

There's something funky with the diff. It seems you have a lot of commits in your diff that are not yours and are from other PRs. Maybe you can merge or rebase your local repo (from upstream) and then git push -f, to simplify the review process?

[Sterbic]

It seems I did a bad rebase, should be fixed now.