Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues in cryptography package #3474

Merged
merged 2 commits into from Nov 21, 2019

Conversation

ilevkivskyi
Copy link
Member

Note: the verifier() methods are not in docs, but they don't look private and are actually used in some code.

@JelleZijlstra @srittau
I think we should try including the cryptography stubs in the upcoming release, so if you have time please scroll through these stubs maybe you will spot some more issues.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no red flags. The only thing I noticed (already in the original contribution): cryptography.x509 is a package in implementation and a module here, but this can be split later, if required.

@ilevkivskyi ilevkivskyi merged commit 8df632b into python:master Nov 21, 2019
@ilevkivskyi ilevkivskyi deleted the fix-cryptography branch November 21, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants