builtins: rename _LT #4579
Merged
builtins: rename _LT #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an obscure type variable name is causing some pretty inscrutable errors. For instance: ``` xarray/core/utils.py:466: error: Value of type variable "_LT" of "sorted" cannot be "K" tornado/simple_httpclient.py:324: error: Value of type variable "_LT" of "min" cannot be "Optional[float]" ``` I think having a more descriptive type variable name here is better for user experience and helps address the "why" of an error.
This was referenced Sep 26, 2020
Closed
JelleZijlstra
approved these changes
Sep 26, 2020
|
I agree, I'm generally not too happy with the PEP 8 recommendation to give typevars very short names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having an obscure type variable name is causing some pretty inscrutable
errors. For instance:
I think having a more descriptive type variable name here is better for
user experience and helps address the "why" of an error. "_LT" is much
clearer in the context of the stub than it is out of context in an error.