update inspect.pyi to use typevars with generics #5658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Seems like this is stuck on ParamSpec support in mypy. |
srittau
added
the
status: deferred
srittau
reviewed
Jun 17, 2021
srittau
removed
the
status: deferred
|
According to #4827 ParamSpec should "work" if you use |
Akuli
reviewed
Jun 17, 2021
This comment has been minimized.
This comment has been minimized.
Gobot1234
reviewed
Jun 18, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: graphql-core (https://github.com/graphql-python/graphql-core.git)
- src/graphql/subscription/subscribe.py:89: error: unused "type: ignore" comment
- tests/execution/test_sync.py:61: error: Redundant cast to "Awaitable[Any]"
paasta (https://github.com/yelp/paasta.git)
+ paasta_tools/deployd/master.py:115: error: Incompatible return value type (got "List[Type[_T]]", expected "List[Type[PaastaWatcher]]")
|
|
You'll need to sprinkle in some |
|
This has a lot of conflicts now. I think much of this change was implemented in other PRs. |
|
Going to close this as stale for now to keep the list of open PRs manageable. If you're still interested in seeing this through, feel free to reopen or open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated some inspect.is* function to use typevars with the generics when a typeguard is involved.