Update AbstractSet instead of set in random and inspect #6574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`collections.abc.Set` was accidentally replaced with `set` in python#6346. The prior is an alias to `typing.AbstractSet`, instead of `builtins.set`. Since `collections.abc.Set` is easily confused with `typing.Set`, it seems clearer to use `typing.AbstractSet` here.
This comment has been minimized.
This comment has been minimized.
|
Thanks for the catch! |
srittau
reviewed
Dec 13, 2021
stdlib/inspect.pyi
Outdated
| @@ -23,7 +23,7 @@ from types import ( | |||
| if sys.version_info >= (3, 7): | |||
| from types import ClassMethodDescriptorType, WrapperDescriptorType, MemberDescriptorType, MethodDescriptorType | |||
|
|
|||
| from typing import Any, ClassVar, NamedTuple, Protocol, Tuple, Type, TypeVar, Union | |||
| from typing import AbstractSet, Any, ClassVar, NamedTuple, Protocol, Tuple, Type, TypeVar, Union | |||
There was a problem hiding this comment.
Considering that we prefer to use imports from collections.abc, I'd suggest to use from collections.abc import Set as AbstractSet. Best of both worlds.
srittau
approved these changes
Dec 13, 2021
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collections.abc.Setwas accidentally replaced withsetin #6346.The prior is an alias to
typing.AbstractSet, instead ofbuiltins.set.Since
collections.abc.Setis easily confused withtyping.Set, itseems clearer to call it
AbstractSethere.