Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncio: use WriteTransport in StreamWriter #7611

Merged
merged 1 commit into from
Apr 9, 2022
Merged

asyncio: use WriteTransport in StreamWriter #7611

merged 1 commit into from
Apr 9, 2022

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Apr 9, 2022

Fixes #7610

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JelleZijlstra
JelleZijlstra approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StreamWriter's own code uses several attributes on the transport that only exist on WriteTransport.

@JelleZijlstra JelleZijlstra merged commit 4055327 into python:master Apr 9, 2022
@Akuli Akuli mentioned this pull request Apr 27, 2022
Closed
@Akuli Akuli deleted the asyncio-writer branch April 27, 2022 12:47
@bmerry bmerry mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asyncio.StreamWriter.transport not specific enough
2 participants
@Akuli @JelleZijlstra